Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced winrm_cmd module #11445

Merged
merged 2 commits into from
Feb 28, 2019
Merged

Enhanced winrm_cmd module #11445

merged 2 commits into from
Feb 28, 2019

Conversation

Yashvendra
Copy link
Contributor

@Yashvendra Yashvendra commented Feb 21, 2019 •
edited by busterb

This PR solves the issue #11440

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • use auxiliary/scanner/winrm/winrm_cmd.rb
  • set RHOSTS [IP]
  • set USERNAME [USERNAME]
  • set PASSWORD [PASSWORD]
  • set CMD [WINDOWS COMMAND]
  • run

@h00die h00die self-assigned this Feb 21, 2019
@Yashvendra
Copy link
Contributor Author

Why is it taking so much time to complete the checking, its been 2 days.

@bcoles
Copy link
Contributor

bcoles commented Feb 28, 2019

Why is it taking so much time to complete the checking, its been 2 days.

It's fine. The tests passed. GitHub doesn't realise for some reason.

@bcoles
Copy link
Contributor

bcoles commented Feb 28, 2019

@msjenkins-r7 test this please

@busterb busterb self-assigned this Feb 28, 2019
@busterb busterb merged commit 31bf6a1 into rapid7:master Feb 28, 2019
busterb added a commit that referenced this pull request Feb 28, 2019
@busterb
Land #11445, always save output with winrm_cmd
ca6508d
msjenkins-r7 pushed a commit that referenced this pull request Feb 28, 2019
@busterb @msjenkins-r7
Land #11445, always save output with winrm_cmd
3fbea00
@busterb
Copy link
Member

busterb commented Feb 28, 2019 •
edited by gdavidson-r7

Release Notes

This updates the winrm_cmd auxiliary module to always log the command output.

@busterb
Copy link
Member

busterb commented Feb 28, 2019 •
edited

Added b22c496. Thanks @Yashvendra

@Yashvendra Yashvendra deleted the winrm branch March 1, 2019 17:47
@mkienow-r7
Copy link
Contributor

I noticed the associated issue is still open, likely because one of the keywords wasn't used in front of the issue number. Would someone please confirm if this PR resolved #11440?

@busterb
Copy link
Member

busterb commented Mar 8, 2019

Thanks @mkienow-r7, I'd say it does the right thing.

@gdavidson-r7 gdavidson-r7 added the rn-enhancement release notes enhancement label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h00die h00die h00die left review comments

Assignees

@h00die h00die

@busterb busterb

Labels
enhancement module rn-enhancement release notes enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Yashvendra @bcoles @busterb @mkienow-r7 @h00die @gdavidson-r7